Weborum Webmaster Forum > Turning Code Into Function

Full Version: Turning Code Into Function

Weborum Webmaster Forum > Web Page Design > PHP

Joe

Sep 8 2005, 11:28 AM

I'm pretty new to placing code into functions ... hence why I'm not very good with it.

I have a snippet of code ... and to cut down on the amount of coding I want to try and place as much of it in a function as possible. The snippet is a login code, it continually checks (on each page) if the user is still logged in with 3 individual checks. These are;

An IP check
Encrypted username check
Session check

All of these are set if the user is correctly logged in (via the login form). The IP and encrypted user name are both stored within cookies. The code I have at the moment is;

PHP

<?php

if(isset($_SESSION['session_name'])) {
echo 'correctly logged in.';
} else {
echo 'session error ... bye bye birdie!';
}

if($_SERVER["REMOTE_ADDR"] == $_COOKIE[Blah]['IP']) {
echo 'IP match! stay logged in';
} else {
echo 'incorrect IP address ... bastardo!';
}

$Enc_Username = $_COOKIE[Blah]['User'];

$sql = "SELECT Name FROM table_name WHERE Encrypted_Username = '$Enc_Username'";
$result = mysql_query($sql, $db);
$count = mysql_num_rows($result);
 if($count == 0) {
 echo 'do not pass go, do not collect $200.'."\n";
} else {
$row = mysql_fetch_assoc($result);
$Name = SafeAddSlashes($row['Name']);

echo "your name : $Name";
}
?>

At the moment I don't have any redirection codes ... just messages ... I'm guessing though if this code were to be placed within a function I'd need return false if any of the checks were incorrect?

PHP

<?php
function CheckIP($CurIP, $StorIP) {
if(!$CurIP == $StorIP) {
return false;
} else {
return true;
}

CheckIP($_SERVER["REMOTE_ADDR"], $_COOKIE[Blah]['IP']);
?>

... maybe ... ?

Thanks for any help.

Joe

Sep 8 2005, 12:09 PM

I have the first two working;

PHP

<?php

// Working SESSION check function.

function CheckSession($Ses) {
if(!$Ses) {
 return false;
} else {
 return true;
}
}

if(!CheckSession($_SESSION['session_name'])) {
echo 'SESSION error!';
} else {
echo 'SESSION set.';
}

// Working IP check function.

function CheckIP($CurIP, $StorIP) {
if(!$CurIP == $StorIP) {
 return false;
} else {
 return true;
}
}

if(!CheckIP($_SERVER["REMOTE_ADDR"], $_COOKIE[Blah]['IP'])) {
echo 'IP error!';
} else {
echo 'IP match.';
}

?>

Not sure if they're the most efficient way of doing it but they work

The last function I'm having trouble with though

xanderman

Jul 23 2006, 12:07 AM

Using functions is a realy great way to cut down the file size of your script, i'll give you a few examples here.

CODE

<?php
$yourscriptvar = "whatever";
//to beable to access this varable in a function you will need to add global $yourscriptvar in your function
function YourFunction ($param1)
{
 global $yourscriptvar;
 if($param1 == $yourscriptvar)
 //u get it im sure.
}
?>

i also notice you use if's and else;s for returning true and false, this is unneed

CODE

function CheckIP($CurIP, $StorIP)
{
    if(!$CurIP == $StorIP)
    {
       return false;
    }
    return true;
}

you can get away with this because as soon as that return is read the function is killed
thus if your if condition isnt met it will skip the return false and go to the return true

This is a "lo-fi" version of our main content. To view the full version with more information, formatting and images, please click here.